Fine tuning #6991

Bugfix for the wireless graphs, reorder everything to the same level
as displayed in the menu and make the spaces even.

Signed-off-by: Thomas Schröder <tschroeder_github@outlook.com>

Since commit b2ad5d724ef8d0f248080109b7098626e5b5c40c enables you to do multiple searches for a firmware upgrade without reloading the page, it was discovered that if the request hash is not reset, you will get the previous build with that specific request hash as the response even if you select new packages.

Signed-off-by: Daniel Nilsson <daniel.nilsson94@outlook.com>

Signed-off-by: Daniel Nilsson <daniel.nilsson94@outlook.com>

The reassignment of the variable that holds the package information once you get a response from the sysupgrade server caused the package list (which is only loaded once when entering the app) to become an array instead of an object (since that's how the response is structured), which gave the result of once cancelling the firmware upgrade, the package list is now an array, making the package list unusable.

This commit updates the variables that shouldn't be changed (data and firmware) to constants and all handle methods to take these values as parameters instead, allowing us to avoid the possible reassignment which will otherwise result in unexpected control flows.

Ref: #6284

Signed-off-by: Daniel Nilsson <daniel.nilsson94@outlook.com>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Signed-off-by: Dirk Brenken <dev@brenken.org>

luci-app-dockerman: check for existing IPAM config

This was added in upstream with https://github.com/lisaac/luci-app-dockerman/commit/7292955a1b415bb60fa2e403bb3a437b4b7f7846 so should be fine for us to add it.

Signed-off-by: Daniel Nilsson <daniel.nilsson94@outlook.com>

This reverts commit 97ebdcbd.

The commit seems to cause errors already before the login screen.
Discussion in https://github.com/openwrt/luci/commit/97ebdcbd

#commitcomment-139871175

Errors like:

 In error(), file [C]
 called from function [anonymous function] (/usr/lib/lua/luci/ucodebridge.lua:23)
 called from function ((tail call))
 In [anonymous function](), file /usr/share/ucode/luci/runtime.uc, line 148, byte 45:
   called from function build_pagetree (/usr/share/ucode/luci/dispatcher.uc:382:73)
   called from function menu_json (/usr/share/ucode/luci/dispatcher.uc:439:26)
   called from function [anonymous function] (/usr/share/ucode/luci/dispatcher.uc:898:24)
   called from anonymous function (/www/cgi-bin/luci:39:13)

  `        return lcall.call(modname, method, ...args);`
   Near here ----------------------------------------^

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>