Skip to content
  1. Jun 09, 2022
  3. Jun 08, 2022
  5. Jun 07, 2022
  7. Jun 06, 2022
    • Sebastian Kemper's avatar
      glib2: update libintl handling · 721838dd
      Sebastian Kemper authored 
      glib2's meson.build runs check cc.has_function('ngettext', args :
osx_ldflags) and, if successful, it never looks for non-libc libintl.
For musl and glibc this test is always successful.

glib2 unconditionally sets ENABLE_NLS, so during compile <libintl.h>
gets included always. But then we have a disconnect when the OpenWrt pkg
is being built with BUILD_NLS=y, because the <libintl.h> will be from
libintl-full but glib2 will not link to libintl-full.

With BUILD_NLS=n there's no problem, because the <libintl.h> will be
from libc.

In lieu of proper libintl detection in glib2's meson build, removing the
SED call from the Makefile together with the added patch sorts this out.
The SED call can be removed because when we force libintl-full use, the
meson build will put the necessary linker flag into the pkg-config file
itself.

Alpine Linux does something similar (see [1]), but they always force
the use of the external libintl. I assume they always go for full NLS
support.

[1] https://git.alpinelinux.org/aports/tree/main/glib/musl-libintl.patch



Signed-off-by: default avatarSebastian Kemper <sebastian_ml@gmx.net>
      721838dd
  9. Jun 05, 2022
  11. Jun 04, 2022