Skip to content
  1. Nov 07, 2018
  2. Sep 21, 2018
  3. Aug 11, 2018
  4. Jul 20, 2018
  5. Jul 16, 2018
  6. Jul 13, 2018
  7. Jul 03, 2018
  8. Jun 30, 2018
  9. Jun 28, 2018
  10. Jun 23, 2018
  11. Jun 17, 2018
  12. May 28, 2018
  13. May 09, 2018
  14. May 05, 2018
  15. May 02, 2018
  16. Apr 05, 2018
  17. Mar 20, 2018
  18. Jan 30, 2018
  19. Jan 20, 2018
  20. Jan 14, 2018
  21. Jan 11, 2018
  22. Jan 10, 2018
  23. Jan 07, 2018
  24. Jan 03, 2018
  25. Dec 28, 2017
  26. Nov 11, 2017
  27. Oct 20, 2017
  28. Apr 15, 2017
  29. Feb 23, 2017
  30. Feb 11, 2017
  31. Jan 28, 2017
    • Cody R. Brown's avatar
      luci-app-upnp: Adding and displaying "Description" to upnp data · dd0b5cfd
      Cody R. Brown authored
      
      
      Getting the Description data from upnp_lease_file. This data often displays the Application Name which made the upnp call. If the upnp_lease_file doesn't exist, it'll just return a blank entry under "Description".
      
      upnp_lease_file order example: TCP:33333:192.168.0.100:33333:1485578298:NAT-PMP 33333 tcp
      As an optimisation, since the upnp_lease_file has only active leases and is ordered by epoch timestamp (5th column above), and since "iptables --line-numbers -t nat -xnvL MINIUPNPD" has active leases and is also displayed in order of rule applied (time). This means the order of these two sources will be the same. This prevents us from "searching" the upnp_lease_file for every rule, and instead for the n'th rule, look at the n'th upnp_lease_file line. As a result we only need to read in one line at a time. For a safety, the upnp_lease_file description is always checked to see if it matches the rule it's being assigned to. If it doesn't match it'll return blank. This means we'll never put an incorrect description to a upnp rule, even if someone messes with the upnp_lease_file.
      This is the case on my system, more testing may be necessary? If this is false we'll need to loop over the upnp_lease_file for every rule, or read in the whole upnp_lease_file once for the iptables loop.
      
      The Description column is added to the upnp_status, and the "Delete Redirect" renamed to "Delete" to make more horizontal space in the table.
      
      Signed-off-by: default avatarCody R. Brown <dev@codybrown.ca>
      dd0b5cfd
  32. Jan 03, 2017
  33. Dec 24, 2016
  34. Dec 20, 2015
  35. Dec 18, 2015
  36. Oct 28, 2015
  37. Oct 21, 2015